abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

Write UT for public methods if it is possible #108

Open capri-xiyue opened 2 years ago

capri-xiyue commented 2 years ago

TL;DR

Write UT for public methods instead of private methods if it is possible

https://github.com/abcxyz/jvs/blob/23cdda185a8fc277ba798bfaf3e34543458f1934/pkg/jvscrypto/cert_action_api_test.go#L306 and https://github.com/abcxyz/jvs/blob/23cdda185a8fc277ba798bfaf3e34543458f1934/pkg/jvscrypto/key_hosting_test.go#L124

Detailed design

No response

Alternatives considered

No response

Additional information

No response