abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

CLI --insecure flag should not disable generating idtoken for requests #174

Closed yolocs closed 1 year ago

yolocs commented 1 year ago

TL;DR

https://github.com/abcxyz/jvs/blob/main/pkg/cli/token.go#L156-L158

With --insecure flag, we now will skip generating the idtoken for requests. But --insecure only means no TLS. We should continue to generate idtoken so the server knows who is requesting.

Expected behavior

No response

Observed behavior

No response

Environment Details

NA

Additional information

No response