abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

Breakglass flow in web app #296

Open yolocs opened 1 year ago

yolocs commented 1 year ago

TL;DR

As identified in https://github.com/abcxyz/jvs/pull/294/files#r1253404326

The UI allows breakglass category but will fail to generate a breakglass token. One immediate fix is to allow the processor to create breakglass token. However, the underlying logic doesn't make sense. Breakglass should be used when JVS is down so the user can bypass it. If JVS web UI is down, there is no easy way for a user to inject a breakglass token (even though they can generate one with JVS CLI) into their web request.

Instead, I'd like to disable breakglass category in JVS web UI for now and figure out how to do breakglass in the web flow.

Expected behavior

No response

Observed behavior

No response

Environment Details

n/a

Additional information

No response

yolocs commented 1 year ago

https://modheader.com/ might be useful