Adjust a bunch of go-plugin implementation details to resolve plugin loading exceptions - Githubissues

abcxyz / jvs

Apache License 2.0

8 stars 0 forks source link

Adjust a bunch of go-plugin implementation details to resolve plugin loading exceptions #298

Closed dandans-verily closed 1 year ago

dandans-verily commented 1 year ago

Specifically fix the following three exceptions while loading the plugins

plugin.ClientConfig.Plugins field need to be set otherwise exception will be thrown from https://github.com/hashicorp/go-plugin/blob/a88a423a8813d0b26c8e3219f71b0f30447b5d2e/client.go#L909
Due to type check, ValidatorPlugin need to implement plugin.GRPCPlugin.
Due to dispense name check, the name need to be consistent with the plugin name.

Link to: #276