abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

add example to release plugin on top of jvs image #314

Closed dandans-verily closed 1 year ago

dandans-verily commented 1 year ago

Link to: #282

dandans-verily commented 1 year ago

I was considering that option as well, but if I put it in jira repo, it can only support one plugin. For the cases where multiple plugins are needed (e.g. both jiraPlugin and gitHubIssuePlugin), something still need to be provided in this repo

yolocs commented 1 year ago

I was considering that option as well, but if I put it in jira repo, it can only support one plugin. For the cases where multiple plugins are needed (e.g. both jiraPlugin and gitHubIssuePlugin), something still need to be provided in this repo

For multi-plugin case, let's defer the decision of where to put it. JVS should provide the base (binary or image) instead of releasing every plugin combination.

dandans-verily commented 1 year ago

I was considering that option as well, but if I put it in jira repo, it can only support one plugin. For the cases where multiple plugins are needed (e.g. both jiraPlugin and gitHubIssuePlugin), something still need to be provided in this repo

For multi-plugin case, let's defer the decision of where to put it. JVS should provide the base (binary or image) instead of releasing every plugin combination.

ok, I am closing this PR now and will send out the one from jira repo in https://github.com/abcxyz/jvs-plugin-jira/pull/24