abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

Update validation error logging #341

Closed jiahaluo closed 10 months ago

jiahaluo commented 10 months ago

Fix https://github.com/abcxyz/jvs-plugin-jira/issues/48

In runValidations method, errors from validation response are joined to validationErr, other errors thrown in the process are joined to internalErr. For internal errors, we log them with error severity and only returns a standard internal error message to the user. For validation errors, we log them with warning severity and return the error messages to the user

Validation error page: https://screenshot.googleplex.com/6nVVX2tM8hEfFMX and https://screenshot.googleplex.com/9YNJXeAm6rC635z

Internal error page: https://screenshot.googleplex.com/Me69mo934DcuqeF

Error logs https://screenshot.googleplex.com/5YHzwbPTr9ktEfx