abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

fix: add plugin_secret_envvars so CR service can get secret directly #379

Closed sailorlqh closed 7 months ago

sailorlqh commented 7 months ago

Add plugin_secret_envvars variables so we can use the secret_envvars from abcxyz/terraform-module/cloud_run, and get secret from secret manager directly.

sailorlqh commented 7 months ago

You'll need to make sure the CR service account has access to the underlying secrets or else it will fail to boot.

Yes, the plugin already has that covered: https://github.com/abcxyz/jvs-plugin-github/blob/main/terraform/modules/secret_manager/main.tf#L63

sqin2019 commented 7 months ago

You'll need to make sure the CR service account has access to the underlying secrets or else it will fail to boot.

Yes, the plugin already has that covered: https://github.com/abcxyz/jvs-plugin-github/blob/main/terraform/modules/secret_manager/main.tf#L63

We should work on an example infra setup in jvs-plugin-github, we may see circular dependencies of the jvs e2e module and the secret_manager module (jvs e2e need the secret version and name, secret manager need the CR sa created in e2e).