search

abcxyz / jvs

Apache License 2.0
8 stars 0 forks source link

refactor: refactor terraform #71

Closed capri-xiyue closed 2 years ago

capri-xiyue commented 2 years ago

refactor terraform

capri-xiyue commented 2 years ago

This PR depends on https://github.com/abcxyz/infra/pull/2. Terraform fails because https://github.com/abcxyz/infra/pull/2 is still pending.

capri-xiyue commented 2 years ago

I also recommend add readme to these modules so it's explicit what they are used for. Currently it's a bit confusing.

done

sethvargo commented 2 years ago

If we're having "instances" of the e2e module, those should be in our private repo though.

capri-xiyue commented 2 years ago

If we're having "instances" of the e2e module, those should be in our private repo though.

Yes. If that's shared "instances", it would be in the private repo. I previously created a dev repo and that repo is for devs to create the functional jvs e2e in their own dev project.

sethvargo commented 2 years ago

I think that terraform/env/* should be moved out of this repo.

yolocs commented 2 years ago

@sethvargo I think terraform/env/* is being deleted in the PR.

sethvargo commented 2 years ago

Yea, I know. I was agreed with @capri-xiyue :)