search

abcxyz / team-link

Apache License 2.0
1 stars 0 forks source link

Use cache for github app installations #27

Closed sqin2019 closed 5 months ago

sqin2019 commented 5 months ago

see https://github.com/abcxyz/pasture/blob/main/pkg/code/github/code.go#L182 instead of https://github.com/abcxyz/team-link/blob/main/pkg/github/synchronizer.go#L75

sethvargo commented 5 months ago

I wonder if the githubauth package should actually do this?

sqin2019 commented 5 months ago

I wonder if the githubauth package should actually do this?

Agree since it is reusable, also cc @yolocs.

sqin2019 commented 5 months ago

Please let me know if I should draft a PR for it in pkg, thanks!

sethvargo commented 5 months ago

https://github.com/abcxyz/pkg/pull/334

sethvargo commented 5 months ago

@sqin2019 you'll need to update the dependency version of pkg to pick this up.

sqin2019 commented 5 months ago

@sqin2019 you'll need to update the dependency version of pkg to pick this up.

Yep, version is updated - https://github.com/abcxyz/team-link/blob/main/go.mod#L6, https://github.com/abcxyz/pkg/releases/tag/v1.1.1