abdalla / react-hotjar

Small component to implement Hotjar into your react application
MIT License
165 stars 32 forks source link

hotjar.initialize Expected 1 arguments, but got 2 #71

Closed sergei-lobanov closed 2 months ago

sergei-lobanov commented 5 months ago

Updating from 6.2.0 to 6.3.1 I see the next issue

TS2554: Expected 1 arguments, but got 2. 47 | }); 48 |

49 | hotjar.initialize(Number(process.env.REACT_APP_HOTJAR_ID), 6); | ^ 50 | 51 | // Initialize Sentry instance before React 52 | initializeSentry();

In the absence of a changelog, it's difficult to determine definitively whether this is a breaking change and something should be changed in the code above or its a bug? 
arifszn commented 5 months ago

Sad to see breaking changes getting merged into minor releases.

hotjar.initialize({ id: Number(process.env.REACT_APP_HOTJAR_ID), sv: 6 });
abdalla commented 4 months ago

PR's are welcome, be my guest to fix.