abdallahmehiz / mpvKt

A media player for android, based on mpv-android and built with Jetpack Compose.
Apache License 2.0
572 stars 18 forks source link

[feature request] remember external audio subtitles #64

Open Sensex00 opened 1 month ago

Sensex00 commented 1 month ago

The app doesn't remember audio and mainly subtitle added from storage after opening it once it will forget and I have to add again

abdallahmehiz commented 1 month ago

this is not possible without WRITE_EXTERNAL_STORAGE permission (audio is but not subtitles).

Sensex00 commented 1 month ago

this is not possible without WRITE_EXTERNAL_STORAGE permission (audio is but not subtitles).

A question for you this should be for later protity,now is the ui and other functionality but I want to know if there's a room battery optimisation or can say android optimization without compromising the video quality which is mpv know for best

Maybe be the answer is no

abdallahmehiz commented 1 month ago

I am not really sure how I would go about implementing such a thing since it's not only dependant on some optimizations here and there but also video codec, screen brightness and other factors. So yes, the answer is most probably no.

Sensex00 commented 1 month ago

@abdallahmehiz sorry I was not clearly stated but I was talking about battery optimisation because app consume battery alot more than vlc maybe because it provide High video output but I want to check if there room for battery optimisation more efficient can you make without compromising with the video quality output

abdallahmehiz commented 1 month ago

@abdallahmehiz sorry I was not clearly stated but I was talking about battery optimisation because app consume battery alot more than vlc maybe because it provide High video output but I want to check if there room for battery optimisation more efficient can you make without compromising with the video quality output

I don't think i can do much for optimizing battery consumption.