abdallahmehiz / mpvKt

A media player for android, based on mpv-android and built with Jetpack Compose.
Apache License 2.0
372 stars 11 forks source link

Feature Request: playlist support #8

Open Brajesh3 opened 2 weeks ago

abdallahmehiz commented 1 week ago

About playlists, do you want them to work like how they do in mpv-android/vlc? or something more akin to what MX Player has?

Brajesh3 commented 1 week ago

Whatever you think is good. I don't know much about mx player so i can't say.

Sumitdesu commented 1 week ago

About playlists, do you want them to work like how they do in mpv-android/vlc? or something more akin to what MX Player has?

I know it's too much to ask but can you implement both types so user can choose whichever they want since many people will have different opinion.

barolo commented 1 week ago

I just want to be able to list entries and have prev/next buttons (so basically like MPV).

abdallahmehiz commented 1 week ago

Seems like the READ_MEDIA_AUDIO, READ_MEDIA_VIDEO and READ_MEDIA_IMAGES are required for this to work (READ_EXTERNAL_STORAGE on Android versions <13)

barolo commented 1 week ago

Seems like the READ_MEDIA_AUDIO, READ_MEDIA_VIDEO and READ_MEDIA_IMAGES are required for this to work (READ_EXTERNAL_STORAGE on Android versions <13)

How so? I don't care about auto-creating playlists out of files but for handling properly playlist files like m3u8. Is it still required in such case?

abdallahmehiz commented 1 week ago

It is still required even if you manually open append files to a playlist with Android's SAF. Navigating through a playlist causes already played files to throw an error similar to this: https://stackoverflow.com/questions/77576335/abort-message-fdsan-attempted-to-close-file-descriptor-102-expected-to-be-un

m3u8 playlists would still work if the media required to play it is from a network source.

barolo commented 1 week ago

m3u8 playlists would still work if the media required to play it is from a network source.

oh that explains it, because that's my main use case. I also use the lower API variant of mpv android, because that one has old type file access, which is needed for Lua scripts to work.