search

abdeladim-s / pywhispercpp

Python bindings for whisper.cpp
https://abdeladim-s.github.io/pywhispercpp/
MIT License
180 stars 26 forks source link

Update whisper.cpp #65

Closed vietanhdev closed 1 month ago

vietanhdev commented 1 month ago

Hi! Thank you for your great package. There has been an upgraded version (v.1.7.0) of Whisper.cpp yesterday. This PR upgrades whisper.cpp library to the latest version.

This also fixes the issue when running in the same program with llama-cpp-python 0.3.1 due to binary incompatible. Error log:

...lib/python3.10/site-packages/llama_cpp/_ctypes_extensions.py", line 69, in load_shared_library
    raise RuntimeError(f"Failed to load shared library '{lib_path}': {e}")
RuntimeError: Failed to load shared library '...lib/python3.10/site-packages/llama_cpp/lib/libllama.so': .../lib/python3.10/site-packages/llama_cpp/lib/libllama.so: undefined symbol: ggml_exp
abdeladim-s commented 1 month ago

Hi @vietanhdev, Thank you for the contribution! I will first push a new version to PYPI first before upgrading whispcer.cpp. I will merge this once the previous version is stable, in the meantime, can you try to run the test suite in the test folder against this new whisper.cpp version and check if everything is OK?

Also I didn't understand what issue are you referring to ? This package has nothing to do with llama-cpp-python and the dll libraries are shipped with the wheel, so basically there should be no issue with any other package!

UsernamesLame commented 1 month ago

LGTM. Resolves https://github.com/abdeladim-s/pywhispercpp/issues/66.