search

abdeladim-s / subsai

🎞️ Subtitles generation tool (Web-UI + CLI + Python package) powered by OpenAI's Whisper and its variants 🎞️
https://abdeladim-s.github.io/subsai/
GNU General Public License v3.0
1.24k stars 101 forks source link

Publish the docker image #144

Open azukaar opened 3 days ago

azukaar commented 3 days ago

Not having the image publish sort of defeat the purpose of having a docker image, it would be nice to have it published to docker hub (you can have a github CI script to auto publish on commit)

abdeladim-s commented 2 days ago

@azukaar, Yes, having the image pre-built is great. I've wanted to do this for a while but haven't had the chance. I've quickly created a GitHub action and pushed the image to Docker Hub. You can find it here. Hope this helps.

azukaar commented 1 day ago

amazing thanks EDIT: just tested it, it seems to work but I noticed you are using :main as a tag, but the best practice is to use :latest at it is the one that allows docker to auto-chose label

abdeladim-s commented 1 day ago

I just followed and used the action from the Github docs. I believe main refers to the main branch and is set automatically here. I think the problem is that metadata-action only sets the latest tag if the main branch is called master and I need to add a hack to make it work with main. Will look into that!