abdeladim-s / subsai

🎞️ Subtitles generation tool (Web-UI + CLI + Python package) powered by OpenAI's Whisper and its variants 🎞️
https://abdeladim-s.github.io/subsai/
GNU General Public License v3.0
1.25k stars 104 forks source link

Incorrect param on WhisperTimeStamped #33

Closed juanchosaravia closed 1 year ago

juanchosaravia commented 1 year ago

Hi! First of all, thanks for this awesome lib!! I love it!

I was testing the WhisperTimeStamped model and reading the documentation on the source code I found the option to set the 'segment_type' with these possible values 'options': ['Sentence', 'Word'], image

but the code expects lowercase value 'word': image

So the Options should indicate the value properly or change the code to accept 'Words'

Took me a while to realize why it was not working.

abdeladim-s commented 1 year ago

Hi @juanchosaravia,

You are welcome. Glad you found it useful :)

Yeah you are right, I think I will just make it small letters in all places. I will fix it quickly.

Thank you very much for taking the time to debug the code.

abdeladim-s commented 1 year ago

@juanchosaravia, Please give it a try now and let me know whether the problem is solved ?

juanchosaravia commented 1 year ago

hey that was super quick! thanks!! Yes looks perfect!

abdeladim-s commented 1 year ago

You are welcome :)