abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

No exception fired on video data loading error #102

Closed krida2000 closed 11 months ago

krida2000 commented 1 year ago

If video loaded from invalid url no exception is fired and MeeduPlayerController.dataStatus not changed to error. How should I handle video loading errors?

Code sample:


await _meeduPlayerController.setDataSource(
        DataSource(
          type: DataSourceType.network,
          source: "https://some-invalid-url.com/video/123.mp4",
        ),
        autoplay: true,
        looping: false,
    );
abdelaziz-mahdy commented 1 year ago

On desktop?

krida2000 commented 1 year ago

On desktop?

Yes, I tested it on Windows.

abdelaziz-mahdy commented 1 year ago

Yes I am still trying to fix that since I couldn't get the error from media_kit

abdelaziz-mahdy commented 1 year ago

Related issue. https://github.com/alexmercerind/media_kit/issues/218

If I got time and found a way to do it , I may open a pr on media_kit for a fix for that problem

abdelaziz-mahdy commented 1 year ago

fixed on 4.2.11-dev-3 please check and reopen it there is any other problem

abdelaziz-mahdy commented 1 year ago

@krida2000 due to problems with my fix, i made the code only log errors, when media_kit provides a better solution i will integrate it, sorry for that

abdelaziz-mahdy commented 12 months ago

should be fixed in this new release since media_kit added error stream