abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

Background for subtitle #113

Closed sommye-ctr closed 1 year ago

sommye-ctr commented 1 year ago

Is it possible to enable or disable the black background on subtitles? image

abdelaziz-mahdy commented 1 year ago

Is it possible to enable or disable the black background on subtitles? image

I will try to make it customizable, where you define your own widget that takes the text

micodev commented 1 year ago

@zezo357 I hope that you make it also customizable at runtime ClosedCaption widget, it can be achieved with valueListenable or through meedu state management I have a question tho, is it going to be any time soon ? (I'm relying on it)

micodev commented 1 year ago

you can also rely on link for fully customized factory subtitle

abdelaziz-mahdy commented 1 year ago

@zezo357 I hope that you make it also customizable at runtime ClosedCaption widget, it can be achieved with valueListenable or through meedu state management I have a question tho, is it going to be any time soon ? (I'm relying on it)

I can make it customizable, and you can handle on run time the customization, since it will be based on each person use case

abdelaziz-mahdy commented 1 year ago

If you can provide a pr that will help me greatly, since I am busy with some work. And will try to do it when I have free time

abdelaziz-mahdy commented 1 year ago

fixed in 4.2.11-dev-8, check and let me know

also you can check the examples https://github.com/zezo357/flutter_meedu_videoplayer/blob/master/package/example/lib/pages/custom_subtitles.dart

sommye-ctr commented 1 year ago

Thanks for the quick merge man :⁠-⁠)

abdelaziz-mahdy commented 1 year ago

Thanks for the quick merge man :⁠-⁠)

you are welcome