abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

partially integrated ForwardAndRewindStyle #138

Open andrezanna opened 11 months ago

andrezanna commented 11 months ago

I've added a partial integration since I need fastly to update the video player in my app.

abdelaziz-mahdy commented 11 months ago

Thank you very much, will check it when I have time, but so far looks good to me .

abdelaziz-mahdy commented 11 months ago

hello, your last commit breaks my github actions can you revert it? changing the package folders is a problem for me , also no need to do it like that

you can get it from github and pick the path for the package

abdelaziz-mahdy commented 11 months ago

example

dependencies:   
     flutter_meedu_videoplayer:
       git:
         url: https://github.com/abdelaziz-mahdy/flutter_meedu_videoplayer
         path: package 

you can put your github url there

andrezanna commented 11 months ago

Hello, sorry for the confusion,

I reverted the commit now. Didn't know about that git feature you mentioned.

Many Thanks

Andrea

abdelaziz-mahdy commented 11 months ago

thank you very much will make sure everything is working as intended and will merge.

abdelaziz-mahdy commented 11 months ago
image

sorry i took sometime to look into this, i dont mind the changes but the slider is a bit weird? dont you think? i think it will be better to have same old look using the colortheme, and if people need to have another color they should define it

i like the idea of being able to customize the widgets, so i am just looking for a way that doesnt break old ui on update but also can be customized like how you did it

what do you think?

abdelaziz-mahdy commented 11 months ago

let me know what do you think about the new changes, also can you add an example for your changes? like a custom styled screen?