abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

Blank screen with ESC key on Windows 11 #144

Closed autocar closed 11 months ago

autocar commented 11 months ago

Hello, on Windows (W11) at the moment of "initstate" meeduPlayerController.setFullScreen(false, context); black screen. or 1 time before making full screen when the player is displayed, After making the full screen, when the ESC key is pressed 2 times, the screen becomes black again.

abdelaziz-mahdy commented 11 months ago

Can you let me know the steps to reproduce it?

Or the code

abdelaziz-mahdy commented 11 months ago

Also, which version are you using, and can you test on latest one?

4.2.19 should be improved

autocar commented 11 months ago

Hello again, Thank you for your answer. The problem still persists with version 4.2.20. If you compile the BasicExamplePage page with Windows and press ESC when it opens, the screen goes black immediately.

This is what happens when you press the ESC key. https://github.com/zezo357/flutter_meedu_videoplayer/assets/5386491/0cb3e070-c97d-4bfc-977d-5a806b7f64ff

abdelaziz-mahdy commented 11 months ago

Hello again, Thank you for your answer. The problem still persists with version 4.2.20. If you compile the BasicExamplePage page with Windows and press ESC when it opens, the screen goes black immediately.

This is what happens when you press the ESC key. https://github.com/zezo357/flutter_meedu_videoplayer/assets/5386491/0cb3e070-c97d-4bfc-977d-5a806b7f64ff

Oh that's an edge case, I never tried that

Thank you for explaining will check it when I have some free time

autocar commented 11 months ago

problem is controller.dart line 994 Navigator.pop(context);

if Navigator.pop(context); I guess there will be no problem if it is checked for fullscreen before calling.

autocar commented 11 months ago

please replace controller.dart line 994 Navigator.pop(context); to if (this.fullscreen.value) { Navigator.pop(context); }

no problem, i am tested.

mobisofts commented 11 months ago

I sent a pull request. Thank you for this library and everything