search

abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

Drag volume control #42

Closed MichalNemec closed 1 year ago

MichalNemec commented 1 year ago

Drag volume control is shown only on landscape mode. Can this be shown on on portrait too?

How to disable this drag volume functionality completely?

abdelaziz-mahdy commented 1 year ago

I didn't implement the option to disable it , I can add it in next release

And It should work in portrait too, so I will check that

abdelaziz-mahdy commented 1 year ago

can you test on flutter_meedu_videoplayer: ^4.0.9-dev.1

disabling volume swipes can be done like this

  final _meeduPlayerController = MeeduPlayerController(
    controlsStyle: ControlsStyle.primary,
    enabledControls: EnabledControls(
      volumeSwipes: false
    )
  );
MichalNemec commented 1 year ago

volumeSwipes works as intended, brightnessSwipes is working. When both are false, brightness is stuck and ui is shown forever

MichalNemec commented 1 year ago

when i have this, then when i press volume button, drag bar is still showing up

    enabledControls: const EnabledControls(
      volumeSwipes: false,
      brightnessSwipes: false,
    ),
abdelaziz-mahdy commented 1 year ago

volumeSwipes works as intended, brightnessSwipes is working. When both are false, brightness is stuck and ui is shown forever

Weird, will test again, that's on mobile right?

MichalNemec commented 1 year ago

yes, tested on android.

abdelaziz-mahdy commented 1 year ago

when i have this, then when i press volume button, drag bar is still showing up

    enabledControls: const EnabledControls(
      volumeSwipes: false,
      brightnessSwipes: false,
    ),

Yes I didn't disable the arrows, since they are not swipes, I will another setting to set them

added a variable for each controll

abdelaziz-mahdy commented 1 year ago

fixed on 4.0.9