search

abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

Is possible to add PIP feature for mobile? #66

Open 0Franky opened 1 year ago

0Franky commented 1 year ago

Hi @zezo357 , first of all thank you for your contribution!

I wanted to ask as the title suggests if is possible to add the PIP feature (for mobile). I noticed there is already a pip control but it only works for the web.

Can you add this feature for mobile too?

Thanks in advance and have a nice day!

abdelaziz-mahdy commented 1 year ago

Hi @zezo357 , first of all thank you for your contribution!

I wanted to ask as the title suggests if is possible to add the PIP feature (for mobile). I noticed there is already a pip control but it only works for the web.

Can you add this feature for mobile too?

Thanks in advance and have a nice day!

I can try to add it for Android, but not sure I can make it work for iOS. If that's what you want let me know

0Franky commented 1 year ago

For Android it would already be a good step.

I saw that even for iOS it is possible to do it now. If it were possible to add the same feature to iOS as well, that would be great.

abdelaziz-mahdy commented 1 year ago

For Android it would already be a good step.

I saw that even for iOS it is possible to do it now. If it were possible to add the same feature to iOS as well, that would be great.

Due to not having an iOS I may not be able to do it.

But I will try anyway.

0Franky commented 1 year ago

thank you very much!

abdelaziz-mahdy commented 1 year ago

@0Franky i was able to do it on android, for ios i would love if you can make a pr. for android you can test on latest branch (check documention website for steps to setup) 👋 👉 Complete documentation here

  flutter_meedu_videoplayer:
    git:
      url: https://github.com/zezo357/flutter_meedu_videoplayer
      path: package
0Franky commented 1 year ago

thank you @zezo357 ! today I'll check it and I'll give you more details.

for iOS I'll try to install MacOS in VM and I'll try to code it using iOS emulator. but I'm not sure about the result because I never programmed in swift.

abdelaziz-mahdy commented 1 year ago

thank you @zezo357 ! today I'll check it and I'll give you more details.

for iOS I'll try to install MacOS in VM and I'll try to code it using iOS emulator. but I'm not sure about the result because I never programmed in swift.

I did try to run macos in vm before and failed, if you managed to succeed let me know the steps

0Franky commented 1 year ago

sure. are you ok Windows or Linux?

however you can refer to this: https://github.com/sickcodes/Docker-OSX

abdelaziz-mahdy commented 1 year ago

sure. are you ok Windows or Linux?

however you can refer to this: https://github.com/sickcodes/Docker-OSX

I am on windows, and will check it thank you

0Franky commented 1 year ago

On Android PIP works well, thank you!

Just a question, to change the PIP UI, can I do it by flutter code?

abdelaziz-mahdy commented 1 year ago

On Android PIP works well, thank you!

Just a question, to change the PIP UI, can I do it by flutter code?

I didn't find a way yet, this is why I didn't release it 😅 if I found a way I will implement it

Most probably we can't change it. But we maybe able to remove some.

abdelaziz-mahdy commented 1 year ago

couldnt find a way to change ui (keep in mind i am not that good with java, nor swift)

for ios , pip will require help from the people

0Franky commented 1 year ago

On Android PIP works well, thank you! Just a question, to change the PIP UI, can I do it by flutter code?

I didn't find a way yet, this is why I didn't release it 😅 if I found a way I will implement it

Most probably we can't change it. But we maybe able to remove some.

Ok in the meantime, can we show the following buttons?

0Franky commented 1 year ago

couldnt find a way to change ui (keep in mind i am not that good with java, nor swift)

for ios , pip will require help from the people

I'll try to write some code in the next days. But I never wrote swift code 😅 nor flutter package

0Franky commented 1 year ago

For ios pip mode I found this fork of video_player https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture

It seems you are using video_player for mobile version.

What do you think about using this fork? Or at least take into account the code as a guide for our.

abdelaziz-mahdy commented 1 year ago

For ios pip mode I found this fork of video_player https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture

It seems you are using video_player for mobile version.

What do you think about using this fork? Or at least take into account the code as a guide for our.

Will check it

0Franky commented 1 year ago

For ios pip mode I found this fork of video_player https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture It seems you are using video_player for mobile version. What do you think about using this fork? Or at least take into account the code as a guide for our.

Will check it

Thank you, I hope it can speed up

abdelaziz-mahdy commented 1 year ago

For ios pip mode I found this fork of video_player https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture It seems you are using video_player for mobile version. What do you think about using this fork? Or at least take into account the code as a guide for our.

Will check it

Thank you, I hope it can speed up

I don't know if it's even possible based on my current knowledge 🥲. Since most people use pip from the player itself so I would have to make my own video_player like how you see in that repo