abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
142 stars 71 forks source link

Fix controls on real devices #74

Closed mohamed-Etman closed 1 year ago

mohamed-Etman commented 1 year ago

Controls worked on the emulator but on real devices only doubletap controls worked

abdelaziz-mahdy commented 1 year ago

Can you recheck if it happens in version 4.2.8, it should be already fixed.

mohamed-Etman commented 1 year ago

Moving the MouseRegion down in the stack fixes the bottom controls but the doubletap doesn't work

abdelaziz-mahdy commented 1 year ago

The problem that you removed the absorb pointer widget, now any button clicks can reach the buttons even though they are hidden, that will be too confusing to people

mohamed-Etman commented 1 year ago

I removed the absorb pointer because it was preventing the doubletap from getting any hits i added ignore pointer instead in the latest commit, now all controls work and the bottom controls only work when visible

abdelaziz-mahdy commented 1 year ago

Ok will test it and merge.

Thank you for the pr.

abdelaziz-mahdy commented 1 year ago

@mohamed-Etman released in 4.2.9

note: i changed the black45 to black26 since it was too dark