search

abdelaziz-mahdy / flutter_meedu_videoplayer

Cross-Platform Video Player for flutter
https://abdelaziz-mahdy.github.io/flutter_meedu_videoplayer/
MIT License
132 stars 69 forks source link

add ControlsStyle.primaryList for scrollable list #89

Closed ADAIN closed 1 year ago

ADAIN commented 1 year ago

Greeting maintainers.

When a video is inserted into a scrollable list, the scroll functionality is disabled due to the drag event. To address this, I added a style to the default controller to allow scrolling.

Features

I am aware that this feature can be implemented with ControlsStyle.custom, but I created it for convenience. If you deem the feature unnecessary, you can simply ignore the pull request.

Thank you.

abdelaziz-mahdy commented 1 year ago

Thank you for your contribution, i really like the idea of having easy configuration for people to use

So I will check your PR when I have time and merge if possible .

abdelaziz-mahdy commented 1 year ago

LGTM!

Note: new release will take some time since there is another PRS in progress, when all finished will merge and release

abdelaziz-mahdy commented 1 year ago

published in 4.2.11-dev