search

abdelaziz-mahdy / universal_video_controls

video controls that can be universally applied to various video players
https://abdelaziz-mahdy.github.io/universal_video_controls/
1 stars 0 forks source link

Playback stops when switching to fullscreen #5

Open kbublitz opened 3 hours ago

kbublitz commented 3 hours ago

Hi, I found another issue with using the video controls.

When switching to fullscreen or back to normal while the video is playing, the playback stops. This happens on all the examples on https://abdelaziz-mahdy.github.io/universal_video_controls/ so it's easy enough to reproduce.

It would be nice if the video kept playing when switching fullscreen state.

abdelaziz-mahdy commented 2 hours ago

What platform are you testing on, since for me it is still playing correctly

kbublitz commented 2 hours ago

I tested on my Windows 10 system, both in Firefox (130.0.1) and Chrome (128.0.6613.139) the playback stops.

abdelaziz-mahdy commented 2 hours ago

I tested on my Windows 10 system, both in Firefox (130.0.1) and Chrome (128.0.6613.139) the playback stops.

will look into it, It looks like a race condition, since it's working for me and not working for you then will make sure there is some type of locking

kbublitz commented 2 hours ago

Thank you, yes it looks like some kind of race condition. I added a debugPrint in fullscreen.dart to print the playing state and now it sometimes works and simetimes it doesn't. The output will either print true or false kind of randomly.

grafik