search

abdelhamiderrahmouni / filament-monaco-editor

A Monaco Editor form field for FilamentPHP.
MIT License
11 stars 1 forks source link

Blade language support? #4

Open caendesilva opened 1 month ago

caendesilva commented 1 month ago

Hey! As a feature suggestion: It would be great if there was native support for Blade code as I think the target audience of this plugin work a lot with Blade.

caendesilva commented 1 month ago

Also @abdelhamiderrahmouni it seems like the config options do not work. In fact, adding dd() to the MonacoEditor::mount() shows that it's actually never called?

I think that instead of mount you should use setUp. (Side note, the default values in the config do not match the default property values)

All in all, thanks for your work on this! I think this can be a very promising plugin.

caendesilva commented 1 month ago

Additionally, a way to customize the height instead of hardcoding to 500px would be awesome, also maybe a hook to add custom styles in a