Refactor according to React best practices

abdennour / react-progressbar

Basic progress bar in React.js

http://abdennour.github.io/react-progressbar/

MIT License

88 stars 28 forks source link

Refactor according to React best practices #16

Closed abdennour closed 8 years ago

abdennour commented 8 years ago

-defaultProps and PropTypes enhance code's readability.

preventOutOfRange is a new method to mitigate render method by externalize logic outside.

paramaggarwal commented 8 years ago

Nice. Thanks!

abdennour commented 8 years ago

@paramaggarwal Happy for collaboration.. I am now working on unit-tests to have nice badges (build:passing, coverage:100%... so no ) . By that, your package will be certified as a mature software.

paramaggarwal commented 8 years ago

Added you as a collaborator.