search

abdennour / react-progressbar

Basic progress bar in React.js
http://abdennour.github.io/react-progressbar/
MIT License
88 stars 28 forks source link

Update dependencies, add Prettier #20

Closed lsanwick closed 4 years ago

lsanwick commented 6 years ago

Resolves issue #19. No real code changes are required to support React 16, as there is no usage of breaking features, as far as I am aware.

I've also added lockfiles for Yarn and NPM to make installation consistent, and installed and run Prettier to format the codebase consistently.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 06e2d0991c8a92a4c28449cc6fdbbb7d696c7dfb on lsanwick:ls/deps-and-prettier into 8977646d5bcd6dbe2ba6177d44f247b9e678be2e on abdennour:master.

tymekg commented 6 years ago

What is preventing this PR from being merged? @abdennour is this package still maintained at all?

lsanwick commented 6 years ago

@abdennour can you take a look at this PR first? This one is mostly just doing some project cleanup and correcting dependencies.

redefinitionof commented 4 years ago

@lsanwick I tried to install your pull request with: npm install --save abdennour/react-progressbar\#pull/20/head But it leaves me without a module: $ ls node_modules/react-progressbar AUTHORS LICENSE package.json README.md Any ideas on how to use a pull request as a dependency and what is going wrong?

lsanwick commented 4 years ago

I don't think you can install a Github branch directly, as the publish step isn't being performed. I think the simplest way to test it out would be to check out the branch locally and build it. You can then test your local version by using npm link

redefinitionof commented 4 years ago

@lsanwick Thanks for the info!