abdhan / gui-lyrics

Instant Lyrics App
GNU General Public License v3.0
1 stars 0 forks source link

Great Startup! #1

Closed elmoiv closed 4 years ago

elmoiv commented 4 years ago

I liked your dark monospace styled GUI 👍

Just for you to know. You can change many properties of my API to suit up your app like:

API.getLyrics(sleep=1)

* Change the time taken to scrape songs:
```python
# Just the same as above but for songs

API.getSongs(sleep=1)

Hope you improve this project to be something great and Thanks for using my API 😊

abdhan commented 4 years ago

Hi @elmoiv Thank you so much for your kind words, for stopping by and for the extra information.

Wouldn't decreasing the time to scrape get a IP ban from AZlyrics or Google? The searching by lyrics is a great feature and I might try to include it in my project. I wonder if you can retrieve the Artist and Title from the AZ Lyrics page with your API (if I search only with getLyrics(api.title)? image Also any plans to scrape album art? :)

The GUI module I am using called DearPyGUI is a really cool module to make easy GUI. You must check try it out.

I must say you have motivated me to improve this project further. Hope you have a great day!

elmoiv commented 4 years ago

Yes decreasing time may get you blocked. This was just a hint about the way you change azapi props.

Yes you can retrieve Original artist and title from AZLyrics.com Page:

If AZLyrics adds Album Arts in the future, sure I will add a function for that.

Hope you a good time :)

abdhan commented 4 years ago

Yes decreasing time may get you blocked. This was just a hint about the way you change azapi props.

Okay. Noted.

* Now `API.title` and `API.artist` to have the scraped names from the page.

This is great. I will add this.

If AZLyrics adds Album Arts in the future, sure I will add a function for that.

This probably won't happen. haha.

Thanks again!