abdolence / gcloud-sdk-rs

Async Google Cloud Platform (GCP) gRPC/REST APIs client implementation based on Tonic middleware and Reqwest.
Apache License 2.0
69 stars 21 forks source link

Missing properties in API specs #162

Open jakajancar opened 4 weeks ago

jakajancar commented 4 weeks ago

Hey,

I'm looking at the instances.insert "REST" API documentation and it has properties maxRunDuration and terminationTime, but this seems to be absent from both the openapi-directory as well as the protobuf interface definitions.

Am I missing something? Have to admit I'm a bit confused by the state of Google APIs 😬

Jaka

abdolence commented 3 weeks ago

Hey,

REST APIs are generated and patched manually by external contributors since Google doesn't provide them officially. So they might missing information or incorrect (we had to patch some fields already even in this project). In general if there is gRPC officially available, it is better since protobuf declarations coming from Google.

In this case, while Google has protobuf declaration, I don't believe it is available officially (on their docs they usually mark it when available through gRPC), this is probably whey they don't bother to update it.

So, there are two options:

jakajancar commented 3 weeks ago

Hey @abdolence,

Thanks for the explanation!

Created a PR upstream: https://github.com/APIs-guru/openapi-directory/pull/1290