search

abdolence / sbt-gcs-resolver

SBT plugin for Google Cloud Storage (GCS) and Google Artifact Registry with Coursier support
Apache License 2.0
28 stars 7 forks source link

Logging every download spams the logs #70

Closed peterrosell closed 4 months ago

peterrosell commented 4 months ago

I noticed that when the plugin downloads an artifact it print a log Receving an artifact from url: <url>". I think this should not be logged as an info log as the plugin replaces the defaultHttpURLConnection`, that doesn't do these logs. Nowadays the sbt logs are not that details.

I would suggest that changing the download and upload log to debug level, if they are still needed for troubleshooting.

abdolence commented 4 months ago

Well, I don't have any objections changing it to debug if it is annoying :) It should be really rare to see it (if cache is leveraged), but like I said, I don't have a strong opinion. Want to make a PR? :)

peterrosell commented 4 months ago

I'm gladly creating a PR for this, but maybe not before the weekend. :)

abdolence commented 4 months ago

https://github.com/abdolence/sbt-gcs-resolver/releases/tag/v1.11.0