bugfix/send props to google

abdolence / sbt-gcs-resolver

SBT plugin for Google Cloud Storage (GCS) and Google Artifact Registry with Coursier support

Apache License 2.0

28 stars 7 forks source link

bugfix/send props to google #8

Closed 987Nabil closed 2 years ago

987Nabil commented 2 years ago

Bugfix: Save props (headers) when setting and add to the Google request

987Nabil commented 2 years ago

@abdolence This makes a) sure that all props are send as header and b) the props throw an exception when called after connected == true

abdolence commented 2 years ago

I've created this PR instead. https://github.com/abdolence/sbt-gcs-resolver/pull/9 Please have a look if this is something you are after.

The reasons:

Support for GET, not just PUT
Having a Map[] of ready to use HTTP headers instead
Using foreach instead of fold to show it has side effects
Not to reimplement setRequestProperty

987Nabil commented 2 years ago

Sorry, I somehow missed the comments. Else I would have responded. I think there might be a problem with your suggestions, but I'll check the other pr