abduallahmohamed / Social-STGCNN

Code for "Social-STGCNN: A Social Spatio-Temporal Graph Convolutional Neural Network for Human Trajectory Prediction" CVPR 2020
MIT License
483 stars 141 forks source link

It's unfair to compare the result with other methods! #30

Closed LabMemNo003 closed 4 years ago

LabMemNo003 commented 4 years ago

https://github.com/abduallahmohamed/Social-STGCNN/issues/27 https://github.com/abduallahmohamed/Social-STGCNN/issues/14

As mentioned in above issues, the author even didn't know how the other methods calculate ADE and FDE, actually the calculations are different, but the author put all the results in one table to show the advance of Social-STGCNN.

I'm new to Human Trajectory Prediction, and I want to know the author's academic purpose.

Thanks!

abduallahmohamed commented 4 years ago

Hi, As I clarified before. First the FDE( which cares about the final step in the trajectory prediction, having a small number there means you didn't accumulate errors alongside your predictions) calculations is the exact same of every other paper. As it's a straight forward equation as in our paper: image The second one is the ADE (which cares about the average error along the whole trajectory predictions), as I clarified before in both #27 and #14 the question is the comparison vs Social-GAN. GAN based methods do one prediction of the whole scene of trajectories, aka all generated trajectories are correlated with each other. In our case we don't have this, we predict the distribution of each prediction point per pedestrian, then we sample. Thus using the minimum of 20 trajectories of GAN methods which is over the scene itself is different from ours. Please do check other paper that doesn't use GAN and have their code open-sourced and you will have a clear view of how this is done.

Nonetheless, this take the minimum of 20 predictions to quantify the accuracy of the model is not the bets way to this. Even if it's adapted through all the paper the correct way to do it is to use a metric between a point and distribution.

Let me know if something isn't clear.