Namespace & Tests fix - Githubissues

abdulapopoola / Stream

Implementation of the functional programming streams concept in JS

MIT License

26 stars 5 forks source link

Namespace & Tests fix #1

Closed logbon72 closed 7 years ago

logbon72 commented 8 years ago

Namespaced stream functions to prevent conflicting
Fixed tests failing due to errors being thrown.

abdulapopoola commented 8 years ago

Thanks a lot for this! And sorry for the extremely late response - got a bit busy and my bad :-1:.

The namespace issue is a valid concern but personally I prefer not injecting stuff directly into the prototype. However a fix might be to wrap things in an IIFE? Would that work?

Thanks a lot once again for the time and effort on this! By the way, would you want to collaborate on a Naija-style FOSS project? Maybe sometime in the future?

logbon72 commented 8 years ago

Yeah, my immediate approach was to use IIFE, but gave up after a while because jsdoc2md was not picking up the documentation of the methods, probably because they were not defined within the global scope.

As per FOSS will be interested in whatever makes it "Naija-style", but yeah I am open to such.

abdulapopoola commented 8 years ago

Ahh,the jsdoc failure is a new one. Created issue #4.

abdulapopoola commented 7 years ago

Closing as the API has moved farther ahead.