search

abdullahkarasan / mlfrm

Other
71 stars 47 forks source link

Chapter 1 #1

Open mshearer0 opened 2 years ago

mshearer0 commented 2 years ago
  1. Had to install plotly:

!pip install plotly

  1. Missing a closing bracket from

rand = np.random.rand(n_assets

3.. portfolio = np.array([port_return(np.random.randn(n_assets, i)) for i in range(1, 101)])

This appears to be varying the number of simulations from 1 to 100 for each of 100 experiments, should it be:

portfolio=np.array([port_return(np.random.randn(n_assets, n_simulation)) for i in range(1,101)])

abdullahkarasan commented 2 years ago

Hello Michael,

Thanks for the feedback.

1) Yes, I did not state that readers should type !pip install plotly. But I can put it on github. 2) This looks like it should be in the book. Let me check the github as well. 3) You are right, but it is not a big deal.

Best Abdullah

On Thu, 9 Dec 2021 at 23:29, Michael Shearer @.***> wrote:

  1. I had to install plotly:

!pip install plotly

  1. Missing a closing bracket from

rand = np.random.rand(n_assets

  1. portfolio = np.array([port_return(np.random.randn(n_assets, i)) for i in range(1, 101)])

This appears to be varying the number of simulations from 1 to 100 for each of 100 experiments, should it be:

portfolio=np.array([port_return(np.random.randn(n_assets, n_simulation)) for i in range(1,101)])

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/abdullahkarasan/mlfrm/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBWTAFLFVDB64LPN7PKWFDUQEGRZANCNFSM5JXMYYOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.