abdullahkhalids / qecft

The book A Methods Focused Guide to Quantum Error Correction and Fault-Tolerant Quantum Computation
Other
17 stars 6 forks source link

Isso integration #10

Closed AnsahMohammad closed 1 year ago

AnsahMohammad commented 1 year ago

Implemented the local integration with isso. Tasks

This draft PR closes #2 once merged

AnsahMohammad commented 1 year ago

@abdullahkhalids I've added a local implementation of the issue. Please review it once.

for now, I have linked the chapters/cec/ with the isso, first make sure to run the server by entering ./forum.sh Then you can normally open the notebook and click on the hyperlink which directs to the Discussion generating page.

This is just initial implementation, open to suggestions. Thank you!

abdullahkhalids commented 1 year ago

I played around with this a bit. This looks good. I really like the idea for the webpage to create the task pages.

Two related comments.

[Discussion](https://abdullahkhalid.com/qecft/solutions/section2.1task1.html)

Hope this makes sense.

Edit: Also please change the virtual environment invocation from venv to the more modern virtualenv.

AnsahMohammad commented 1 year ago

Are you suggesting to display the markdown string for the link instead of redirecting to the task-comments page ?

Or do you want to add the markdown string along with the Task-comments page ?

abdullahkhalids commented 1 year ago

Are you suggesting to display the markdown string for the link instead of redirecting to the task-comments page ?

Yes. No redirects. Just on the same "create page" show the markdown for the link, and perhaps just the link itself in case I want to check out the task page.

AnsahMohammad commented 1 year ago

Okay!!, I thought that page was meant for users. Now it makes more sense 👍. I'll make necessary changes asap

AnsahMohammad commented 1 year ago

@abdullahkhalids Check this out now!

abdullahkhalids commented 1 year ago

This looks very good. This is basically ready. Just some minor changes.

Finally, to include you in the contributors list, can you

AnsahMohammad commented 1 year ago

Full Name: Mohammad Ansah Contact: mohdansah10@gmail.com

I agree to release all the code I have written for this repository under the GPLV3 license.