abdullahkhursheed22 / factsilove

My Obsidian vault on GitHub.
Other
25 stars 1 forks source link

Media and other Sources #4

Open Hamath-Eltrael opened 1 year ago

Hamath-Eltrael commented 1 year ago

Making a new issue for the Sources problem, to keep it organized. This started on #3 .

Hamath-Eltrael commented 1 year ago

If possible assign me to this and the License issue, so I don't overlook it. Thanks!

abdullahkhursheed22 commented 1 year ago

Hey! So the texts are all original. I learned most of the information from video sources anyway, so I summarized and reworded it myself.

For the images used, it's either screenshots from videos or pictures from Google. I created the GIFs and one video clip by cropping YouTube videos. If it's not that big of an issue, we can skip this task since it will be a hassle for you.

Hamath-Eltrael commented 1 year ago

That's perfect for the text!

And for all the Media, it is your decision. Let me tell you something though: depending on the licenses that the media are put under by their Creator it is possible that they might send you a takedown notice, or worst case sue you and every who has a public fork.

Or nothing might happen. That's why I offered myself to look into them. But I can also just not do that and we'll see what happens, if something ever happens.

Hamath-Eltrael commented 1 year ago

Then I'd have some time to improve and expand the content!

abdullahkhursheed22 commented 1 year ago

depending on the licenses that the media are put under by their Creator it is possible that they might send you a takedown notice, or worst case sue you and every who has a public fork.

I didn't know that! In that case, it'd be better to be safe than sorry. If you have experience with this, then I would like to do everything to help you with that. Otherwise, should I also look into how to properly find sources and credit media as well?

abdullahkhursheed22 commented 1 year ago

By the way, I am really impressed by the enthusiasm you have for the project and I couldn't be more thankful. Would you mind sharing what enabled such a mindset? I think I can learn from it and apply it in my own life.

Hamath-Eltrael commented 1 year ago

By the way, I am really impressed by the enthusiasm you have for the project and I couldn't be more thankful. Would you mind sharing what enabled such a mindset? I think I can learn from it and apply it in my own life.

Well, I'd say it's the fact that there are just so many cool and half-random facts here! I love this and I also love learning new interesting stuff. I'd also love to contribute my knowledge, but I feel that this is the best I can do at the moment. But I'm hoping that we can make this to a kind of Wikipedia but for only the interesting stuff, easy to understand and connected visually. No overly technical language and partially like a kind of written VSauce I guess? I might just be my love for facts, that are easy to remember, understandable and cool.

Hamath-Eltrael commented 1 year ago

depending on the licenses that the media are put under by their Creator it is possible that they might send you a takedown notice, or worst case sue you and every who has a public fork.

I didn't know that! In that case, it'd be better to be safe than sorry. If you have experience with this, then I would like to do everything to help you with that. Otherwise, should I also look into how to properly find sources and credit media as well?

Warning: While we do this, we shouldn't add any new media to the project!

I can do this. No problem. It's mostly a matter of plugging stuff into google Pictures and see what license the website uses.

If you want to do stuff I could either:

It sadly does not really make sense to split one of those above. If I could freely choose, this would be the way I'd like it to do:

  1. You Plug the Pictures (images folder) into Google.
  2. Make a new Issue for each new Site you took an image from, add a basic link to any page (preferably the homepage) to the first comment. Note the Name of each Picture in the subsequent comments(in case we need to replace them)
  3. If there is already an Issue for the Site the image was taken from, don't create a new one.
  4. I'll look at their License and make pull-request changes accordingly, I'll try to reference the Issue for these, so it's linked
  5. I can do this while you are still adding more pictures to that Sites issue, for all that don't have to be taken down or need a special something for each single picture. Usually a: "We took pictures from ____ site, thank you." Should be enough.
  6. If the Picture(s) form that Site have to be taken down, I'll mark that in the Issue for that Site.
  7. After I mark that, you can (once create) and assign a label for that to that Sites Issues.
  8. For those that have to be changed, we'll do them all at once for each Site at the end, when all pictures have been googled.
  9. for that, we should try to do all from on site in one pull-request. Just to keep it organised
  10. We can split these by Site if you assign the according Issues.
  11. DONE(I think)
Hamath-Eltrael commented 1 year ago

After we do this License Cleanup, we should make sure we don't have to do it again. For that we need a system to add Sources when adding Media.

There are two ways I'm aware of, at the moment:

Hamath-Eltrael commented 1 year ago

We should try to keep the Site issues clean of all but the filenames in the comments, you can just reference them in a new/other issue.

Also, if you need me to elaborate, do ask! I don't know how well I got my point across. I can also create examples, if you want.

Hamath-Eltrael commented 1 year ago

Oh and do let me know how we'll continue and if you have any other ideas or suggestions just say it!

abdullahkhursheed22 commented 1 year ago

but for only the interesting stuff, easy to understand and connected visually

I'm glad you like the facts! This is exactly why I wanted to create one in the first place. I'd learn about interesting facts every 20 pages of a book or every 30 minutes of a podcast. They were all over the place and there were no images to go along with them. So, I wanted to simplify the language and add pictures to make them appealing and easy to learn.

  1. You Plug the Pictures (images folder) into Google.

I can try starting with this. I'm new to GitHub too but I'll watch a quick tutorial on creating and managing issues. For now, I was thinking of creating a list of media and its sources in a Google Sheet.

Hamath-Eltrael commented 1 year ago

I can try starting with this. I'm new to GitHub too but I'll watch a quick tutorial on creating and managing issues. For now, I was thinking of creating a list of media and its sources in a Google Sheet.

That's also a good possibility. Using Issues on GitHub is what we're currently doing, should also be easy. And the way with one issue for multiple images form the same source and having the all images listed as comments makes discussions easy and documents them. And one can just look at the issues and see what to do with new images from that source. So let's say we have currently images from an blog site that doesn't allow usage of their images, then we could document that in the issue, and see there witch images to remove. and in the pull request one can mention the issue when replacing one or all images, so it can be closed with the PR and in the Future, if I, you or someone else want's to add a new image from that site they and most importantly you can see that it's from that site and not to be used.

Shall I do an example Issue for one of the images?

abdullahkhursheed22 commented 1 year ago

Shall I do an example Issue for one of the images?

Sure! That'd be very helpful.

Hamath-Eltrael commented 1 year ago

See #8 for example. Although it is a bad one, since it's not originally from that site. If you could add a "Sources" Label to that issue the example would be complete.

Hamath-Eltrael commented 1 year ago

And as you hopefully can see, we would create an Issue for each site that we took an issue from. We'd simply add another comment with witch file also is from that site.

abdullahkhursheed22 commented 1 year ago

Hey! Thank you for explaining the process.

  1. I created the "sources" label for issues on media sources.

  2. I created two new issues as examples and would like your feedback.

I searched for sources by uploading the files on Google Images. There were many different search results for each and I couldn't tell which ones were the original; so I selected the very first ones. I have attached an example of the search results I got below:

image

If I did everything okay, then I'll start creating issues on each media source for all the other files. I will be working on this and in the meantime, I will not upload any new files to the vault as you suggested.

abdullahkhursheed22 commented 1 year ago

Also, I don't know much about the next steps once all sources have been identified. So I'd also highly appreciate it if you could let me know how this information will be added to Obsidian and how it will help us integrate licenses. Thanks!

Hamath-Eltrael commented 1 year ago

10 <--- is the wrong way round

11 <--- this is looking good! Now if you'd have a second image from Shutterstock, you could just add them as another comment on #11

abdullahkhursheed22 commented 1 year ago

Makes sense! I'll start doing this.

Hamath-Eltrael commented 1 year ago

Thank you very much. I'll get started with them ASAP. Hopefully tomorrow.

Also, as I noticed that you deleted an issue, it's considered good etiquette to not delete issues. I get why you might do it, but I'd recommend not to in the Future. Of course you can delete issues and comments that are downright offensive, but other than that, there probably isn't a reason. You can just close the issue with a comment staying the error. That leaves a better trace for future reference. there's other stuff you could do, but that's just overkill for us at the moment.

abdullahkhursheed22 commented 1 year ago

Okay, that makes sense. I understand. Thank you for letting me know.

I did my bachelors in computer engineering but never got the chance to use GitHub for some reason. And I completely shifted my career direction after graduation. So I'm not familiar with best practices.

Hamath-Eltrael commented 1 year ago

Absolutely no problem! And just wanted to let you know.

Hamath-Eltrael commented 1 year ago
abdullahkhursheed22 commented 1 year ago

Understood! As you know, I'm working on the first three items right now.

Hamath-Eltrael commented 1 year ago

Yes, that's great! I'll try to do 4. as much as possible. But I just got a new job that has priority.

One more thin thought: please assign me to those issues, it should keep them on my radar and give me the ability to close them when they're done. See down the page for how to do multiples at once: https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users

abdullahkhursheed22 commented 1 year ago

Congrats and best of luck on your new job!

It seems that I can assign issues to you that you have created, but not the ones I have created. It does not suggest your name for the issues I created:

image

abdullahkhursheed22 commented 1 year ago

By the way, I'm pretty sure that the search results on Google Photos have gotten worse for some reason.

It keeps suggesting social media accounts and foreign sites instead of the actual sources. For example, I got some images from Wikipedia but it suggested someone's Twitter or Reddit account who reposted it.

I'm not sure what the issue is here.

Hamath-Eltrael commented 1 year ago

Hmmm, that'll make it more interesting... I just hope most are good. Those will be a bit to a lot more work. But we'll get to them then.

Sadly there's not much one can do to get the sources easier.

Hamath-Eltrael commented 1 year ago

But the one nice thing of license is you just have to get one from someone, you can assume that they are allowed to allow you usage or will otherwise tell you who to ask. (As far as I know a believe)

abdullahkhursheed22 commented 1 year ago

Okay, makes sense!

And how do I resolve this problem of assigning issues to you:

It seems that I can assign issues to you that you have created, but not the ones I have created. It does not suggest your name for the issues I created.

Okay, apparently I can also assign issues to you that you have commented on.

Hamath-Eltrael commented 1 year ago

Ok, so I'll put a comment on the ones I started doing something and then you can assign me.

abdullahkhursheed22 commented 1 year ago

Okay! I have created issues by adding the sources for all media. I look forward to hearing from you on how I can help with the next steps. @Hamath-Eltrael

abdullahkhursheed22 commented 1 year ago

Hey! Since it's been a while, I was thinking I should keep adding more content to Obsidian and I'll create issues for whatever media I add along the way.

Hamath-Eltrael commented 1 year ago

Yes, I’m Very Sorry. The Life is getting in the way. But yes. That’ll work.

Am 13.08.2023 um 21:39 schrieb Abdullah Khursheed @.***>:

Hey! Since it's been a while, I was thinking I should keep adding more content to Obsidian and I'll create issues for whatever media I add along the way.

— Reply to this email directly, view it on GitHub https://github.com/abdullahkhursheed22/factsilove/issues/4#issuecomment-1676445432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOMHUIGL6D5ZRYHCK7G56F3XVEUP5ANCNFSM6AAAAAAZTLNCLI. You are receiving this because you were mentioned.

abdullahkhursheed22 commented 1 year ago

No worries at all! I completely understand and you're doing a huge favor. Please take your time.