search

abdulmecit / cmpesweng2014group1

Automatically exported from code.google.com/p/cmpesweng2014group1
0 stars 0 forks source link

Code review request #88

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Please review the code in 6564420.

Original issue reported on code.google.com by abdulmec...@gmail.com on 3 Dec 2014 at 8:34

GoogleCodeExporter commented 8 years ago

Original comment by ayhanc...@gmail.com on 3 Dec 2014 at 8:43

GoogleCodeExporter commented 8 years ago 
In UserController.java:

-viewProfile() method is well done, but it can be improved by adding a path 
variable for user_id instead of getting it from the session 
-updateUser() method looks very redundant, there might be better ways to 
implement
- empty checks in updateUser() method don't redirect the error message before 
returning

In jsp pages:
- headers are very similar between pages, and they can be further collected in 
a header.jsp page and then included in these
- other parts are good, but some comments would be helpful

Original comment by ayhanc...@gmail.com on 3 Dec 2014 at 9:26