search

abdulrahim46 / Nimble

0 stars 0 forks source link

Testing issues #11

Open minhnimble opened 2 years ago

minhnimble commented 2 years ago

It is quite nice to see that you've included a few unit tests and UI tests 👍. I am wondering if we could increase the unit test coverage to cover more the layers of the application? One part you can and should focus on is actually the ViewModel layer, where it contains the important logic in our application. 🙏

abdulrahim46 commented 2 years ago

Yes, I try to cover some unit tests but yeah agree with you on ViewModel layer, need to cover ViewModel 100% for unit tests. So, I was thinking to implement different protocols for different apis that we will conform in ViewModels; that way we can also mock apiclient by writing a MockAPIClient and conforming it to same protocols that we used in ViewModels and then we can mock data through it. What do you think?

minhnimble commented 2 years ago

Sounds good to me. I can't wait to see the implementation 👍