search

abdulrahim46 / Nimble

0 stars 0 forks source link

Network layer #12

Closed abdulrahim46 closed 2 years ago

abdulrahim46 commented 2 years ago

Network layer & DI for view models

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
| Secret | Commit | Filename | Detected At | | | ------------------------- | ---------------- | --------------- | -------------------- | -------------------- | | Generic High Entropy Secret | d384ca0c1db85f1894a7e2ac9fbc0dea2a228f70 | NimbleTests/LoginViewModelTests.swift | 19:22 December 14th, 2021 | [View secret](https://github.com/abdulrahim46/Nimble/commit/d384ca0c1db85f1894a7e2ac9fbc0dea2a228f70#diff-92db0f8ef5d5e3861d9da0f526b1818ac704e48b0c7d8cf517ccf93812f55127R32) | | Generic High Entropy Secret | d384ca0c1db85f1894a7e2ac9fbc0dea2a228f70 | NimbleTests/LoginViewModelTests.swift | 19:22 December 14th, 2021 | [View secret](https://github.com/abdulrahim46/Nimble/commit/d384ca0c1db85f1894a7e2ac9fbc0dea2a228f70#diff-92db0f8ef5d5e3861d9da0f526b1818ac704e48b0c7d8cf517ccf93812f55127R33) |
🛠 How to resolve this 1. Understand the implications of revoking this secret by examining where it is used in your code. 2. Replace and store your secret safely. Learn [here](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/private_key_openssh#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) 4. If possible, [rewrite your git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

:bulb: To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests