search

abdulrahman1s / fem-dl

Frontend Masters Course Downloader That actually works.
https://npmjs.com/package/fem-dl
The Unlicense
164 stars 28 forks source link

Fix for issue #14 - Not able to download 1080p on some videos #16

Closed JMSantos94 closed 1 year ago

JMSantos94 commented 1 year ago

Attempt to fix issue #14

Looks like Frontend Masters have different names for their 1080p versions.

Looking at: https://frontendmasters.com/courses/web3-smart-contracts/introduction/

image

There is not "Q10" in their 1080p format.

However, this seems to vary for some newer videos such as: https://frontendmasters.com/courses/web-auth-apis/introduction/

image

In the newer videos, they do use "Q10" for their 1080p format.

Note: an ideal fix should be doing a fussy match in the "qualities" check loop here: https://github.com/abdulrahman1s/fem-dl/blob/master/src/index.js#L149 multiple versions of the 1080p string. Unfortunately, at this moment I am traveling so I don't have my PC to test such changes and create a PR.

abdulrahman1s commented 1 year ago

Thank you for submitting your pull request and taking the time to investigate the issue. I am pleased to inform you that a new version has been released which includes a fix for the reported issue. Thank you for your contribution! npx fem-dl@latest v0.1.7