abe33 / atom-pigments

An Atom package to display colors in project and files.
MIT License
521 stars 68 forks source link

Pigments not showing colors past window height. #333

Open Mootly opened 7 years ago

Mootly commented 7 years ago

This is specific to color coding with any of the dot options (dot, square, gutter). The highlight options still work correctly.

After a recent update, pigments stopped showing colors after the first 52 visible lines of the file. An older install of atom (0.39 and 0.13) works just fine on the same files). This is specifically happening at line 52 with the font set to 12px. Changing the font size or line height move the break point up and down. Math works out to failing at 936 pixels or thereabouts, seemingly no more meaningful that 52 lines of text. image

If the line height does not evenly divide into 936, then the break occurs mid-line with an alpha-box blow where the color breaks. Collapsing lines moves the break point down correspondingly.

image

This occurs for all file types tested so far (SCSS, CSS, HTML, PHP).

No idea if it is pigments or atom 1.19. Other packages are acting wonky, but usually with error popups.

Pigments 0.40.2
Atom 1.19.0
Windows 10 Pro 15063.502
Mootly commented 7 years ago

Same problem on Mac with:

Pigments 0.40.2
Atom 1.20.0-beta1
MacOS 10.12.6

Again, all dots (dot, square, gutter) ending at a hard pixel point down the document, highlights work normally.

ggedde commented 7 years ago

Same Problem on Mac. Switching it to Underline for now, but prefer Dots.

Pigments 0.40.2 Atom 1.19.0 MacOS 10.12.6

lorenzos commented 7 years ago

Same on Ubuntu 17.04, Atom 1.19.0 and Pigments 0.40.2

robhuska commented 7 years ago

Same problem. I also noticed that using any of the styles that do this hard cut off (dots, square, gutter), it also causes serious lag farther down the document. Using the background, underline, or outline is fine.

drumline18 commented 7 years ago

If I remember correctly, on the last version I had before I updated, there was a non "native" dot option which does not seem to be there at all now. And the native ones perform very poorly (lag, alot). Were these removed?

Pigments 0.40.2
Atom 1.19.1 x64
Windows 10 Pro 15063.540
philecker commented 7 years ago

I'm having the same issue with native dots, not displaying. I agree with @drumline18 that I thought there were non-native dots in a previous version.


Pigments 0.40.2
Atom 1.19.1
MacOS 10.12.6
SeanBurkeDesign commented 7 years ago

Same issue here. background, underline and outline work fine. dot, square-dot & gutter do not work after a certain line.

Pigments 0.40.2 Atom 1.20.1 MacOS 10.11.6

Mootly commented 7 years ago

For everyone playing at home, line 27 of pigments.less. Remove the background-attachment line, restart atom. Problem appears to be resolved so far on Windows and Mac in most recent stable version of Atom and in most recent beta version.

(Previously I said change it to background-attachment: absolute, then realized absolute is not a valid value. So it had the same effect as just removing it.)

Mootly commented 7 years ago

Duplicate bug reports:

348

353

Snuggle commented 7 years ago

@Mootly's fix worked for me. c:

Cxarli commented 7 years ago

@Mootly Could you issue a PR for that? If it works for everyone, I'll gladly merge it :smile:

Mootly commented 7 years ago

Hmmm, looks like there is already a pull request from someone else for the same fix.

Well, that was easy then. XD

2E0PGS commented 6 years ago

Same happening here on Ubuntu.

@Mootly RE: "Again, all dots (dot, square, gutter) ending at a hard pixel point down the document, highlights work normally."

Yes only the native-background and native-outline works for me properly.