Cannot read property 'includeInto' of undefined

[Asteb612]

tablr version 1.8.3 atom version 1.27.0 with atom-ide This message is on the open view.

[higorhi]

After updating Atom, Tablr will no longer open Table Editor issuing the same error: Cannot read property 'includeInto' of undefined

Still shows the preview, though, except after selecting Table Editor mode.

Atom 1.28.0 Tablr 1.8.3

[TakashiAoki]

I am also. I get the same error message.

[duncdrum]

same on macOS 10.13.5

[brundonsmith]

Same here, Windows 10 Atom 1.28

[rvsandeep]

Same here on Ubuntu 18.04

[syrsly]

Same here, just submitted a duplicate issue, sorry about that.

[kguidonimartins]

Same here on Ubuntu 16.04

[ludovicriffault]

Same here with Atom 1.28.0 x64 on macOS High Sierra

[pjnr1]

Same here; Atom 1.28.0 macOS High Sierra 10.13.4 tablr 1.8.3

[acrenwelge]

Same here Atom 1.28.0 Windows 10

[franiis]

Same in: Atom 1.28.1 x64 tablr 1.8.3 Windows 10

[wataru129]

Same here atom 1.28.0 macOS High Sierra 10.13.4

[pstaubs]

Issue persists in atom 1.28.2/tablr 1.83 and essentially renders the package usless.

[dsananez]

Same here. Atom 1.28.2 W10. Could someone fix this? ty

[Semihal]

Likewise.

[spettifer-fdb]

Given there have been no commits for at least a year I'd guess the author is no longer supporting this so unless it turns out to be a core problem in Atom (seems unlikely since more people would be shouting about broken stuff), then it's simply a breaking change in Atom that may or may not get fixed in tablr depending on whether or not the author resurrects it or someone submits a PR or forks it. I'd have a crack but I suspect it's well beyond my javascript skills.

[calgacus]

Seems to hit a snag deep in vm.js line 56: return realRunInContext.call(this, contextifiedSandbox, options);return realRunInContext.call(this, contextifiedSandbox, options);
That return the undefined that gets returned to pool.js around line 66:

const mixin = vm.runInContext(source, context, ${plural}-pool.vm) mixin.includeInto(this) //-- this is where the exception gets thrown.

All those runInContext APIs are new to me so I doubt I can take this anywhere anytime soon. Shame, I had just found this package and for a few tests it worked great then I hit this bug and which renders it useless, it could have been very useful. I really hope it gets fixed.

[mfripp]

@calgacus, it looks like I was debugging this at the same time as you (wish I'd seen your comment first, although it might have scared me off!). I just posted a pull request that seems to fix this, at least for me. If you want, you can install it via

apm uninstall tablr
apm install https://github.com/mfripp/atom-tablr.git

I don't intend to do anything more with this fork, but it may help people use this great package until the main code gets fixed.

[calgacus]

Thanks! It works for me.

[tomasztyzaj]

Thanks @mfripp, worked for me too on MacOS High Sierra 10.13.6 and Atom 1.28.2

[spettifer-fdb]

Yep, W10 Atom 1.28.2 working fine. Thanks for the fix!

[a-paul-taylor]

Fixed it for me (1.28.2 W7) - thanks!

[kguidonimartins]

Thanks, @mfripp! Working fine too on Ubuntu 16.04 and Atom 1.28.1

[piuccio]

Seems to be broken again on Atom 1.29.0

[spettifer-fdb]

@piuccio Are you sure you haven't accidentally updated the package? The fork provided by @mfripp will show as being an older version so Atom's package manager will 'update' it to 1.8.3 if you let it and that will overwrite the fix. Until an official release happens, you will need to ignore all updates to tablr if you want it to keep working. I am running Atom 1.29.0 and it is working fine with the fork.

[piuccio]

oh cool, sorry I missed the https://github.com/abe33/atom-tablr/issues/100#issuecomment-406904774 about installing from a fork. Yes it works fine now

[spettifer-fdb]

@piuccio Great!

[randy]

@mfripp, any chance you can also throw in the fix for #93? https://github.com/abe33/atom-tablr/issues/93#issuecomment-347242628

[puttkraidej]

work like charm!

[alanzzhao-toast]

on macosx. tried the terminal commands, but get

Couldn't clone https://github.com/mfripp/atom-tablr.git what am i doing wrong?

[dschneiderch]

@alanzzhao-toast make sure you have git installed and available on your PATH

[skytreetower]

@mfripp

I run Atom 1.32.1 for Win10. I installed the ‘tablr’ package and ran into https://github.com/abe33/atom-tablr/issues/100. I searched for ‘atom-tablr’ package in both Atom and on the webpage with no hit. So I uninstalled ‘tablr’, cloned the git repo https://github.com/mfripp/atom-tablr.git and copied the directory structure to the .atom\packages directory. Restarted Atom but the package seems to be not running. I cannot open a single CSV file, also the preferences dialog does not open up. So it seems like the package is not running. What did I do wrong and how can I get it to work? Once it is working, can I configure Atom in a way that it always opens all CSV files with the same settings? We only have semicolon separated files, and I do not want to configure the settings anew for each file I open. And is it possible to detect any text file without suffix as CSV as well? All our interface files that we get from partners and send there have no file extension.

[Palmstroemen]

@mfripp Why not use the installation process as described above? Maybe packages need to be registered somewhere in a config-file of Atom. Yes to all your questions. Yes you can define the default settings and yes you can define which file-suffix to be opened automatically with the tablr-extension.

[EvilRenegade]

@calgacus, it looks like I was debugging this at the same time as you (wish I'd seen your comment first, although it might have scared me off!). I just posted a pull request that seems to fix this, at least for me. If you want, you can install it via

apm uninstall tablr
apm install https://github.com/mfripp/atom-tablr.git

I don't intend to do anything more with this fork, but it may help people use this great package until the main code gets fixed.

As of 2019-04-19, this is still the solution to get it to work.

[damianobarbati]

+1

[clearzale]

@calgacus, it looks like I was debugging this at the same time as you (wish I'd seen your comment first, although it might have scared me off!). I just posted a pull request that seems to fix this, at least for me. If you want, you can install it via

apm uninstall tablr
apm install https://github.com/mfripp/atom-tablr.git

I don't intend to do anything more with this fork, but it may help people use this great package until the main code gets fixed.

Amazing, thx!

[TSDAdam]

@skytreetower I had the same issue as you. I got it working by doing:

• Install standard tablr, the non-working one
• replace the copy of lib\mixins\pool.js in your own .atom folder with the one here > https://github.com/mfripp/atom-tablr/blob/master/lib/mixins/pool.js

That worked for me on windows.

[philipsimonhall]

For the record, this also worked for me on Fedora 30 with Atom 1.39.1, just remember to have git installed for installation steps to work, that caught me out temporarily.

[PaoloC68]

apm uninstall tablr
apm install https://github.com/mfripp/atom-tablr.git

This worked for me too on a Mac.

[s0q]

@skytreetower I had the same issue as you. I got it working by doing:

* Install standard tablr, the non-working one

* replace the copy of lib\mixins\pool.js in your own .atom folder with the one here > https://github.com/mfripp/atom-tablr/blob/master/lib/mixins/pool.js

That worked for me on windows.

This also worked for me on windows, excellent work!

[thebestpol]

@mfripp Thanks for sharing it works

[eirerocks]

@mfripp - thanks that pull request worked for me - don't know what you did but it works! it would be good if the original author could have a look and update main for latest Atom

[darkn3rd]

Still happening on mine 1.8.3

[layerssss]

apm uninstall tablr apm install https://github.com/mfripp/atom-tablr.git

As of 13 March, 2020, this is still the solution.

[ulysse42]

apm uninstall tablr apm install https://github.com/mfripp/atom-tablr.git

Same problem, can confirm this still works

[maartenderie]

@abe33 I've you're not going to maintain the project; please find someone who will.

[arvinyorro]

@calgacus, it looks like I was debugging this at the same time as you (wish I'd seen your comment first, although it might have scared me off!). I just posted a pull request that seems to fix this, at least for me. If you want, you can install it via

apm uninstall tablr
apm install https://github.com/mfripp/atom-tablr.git

I don't intend to do anything more with this fork, but it may help people use this great package until the main code gets fixed.

After 2 years, the fix still works

To anyone else who do not know where the pool.js is located, its in C:\Users\{username}\.atom\packages\tablr\lib\mixins

[ujLion]

At: %userprofile%.atom\packages\tablr\lib\mixins replace pool.js with https://raw.githubusercontent.com/mfripp/atom-tablr/master/lib/mixins/pool.js And relaunch

[BhaveshDiwan]

At: %userprofile%.atom\packages\tablr\lib\mixins replace pool.js with https://raw.githubusercontent.com/mfripp/atom-tablr/master/lib/mixins/pool.js And relaunch

Confirmed to fix the issue in MacOS Catalina 10.15.5

[ApplyCyber]

Work for me on Mac. Thank you!!