abe33 / atom-tablr

Edit CSV files using a table editor
MIT License
164 stars 44 forks source link

Can't undo sorting #23

Closed p0la closed 8 years ago

p0la commented 8 years ago

Hello, Thanks for the good work!

When clicking on a column name (say column F), the array will be sorted based on the content of this column, but the file is not considered modified by atom (no modified blue dot indicator in the tab selector) and the undo operation is not working (Ctrl Z does notthing).

Thanks a lot.

abe33 commented 8 years ago

That's because the table was not actually modified, it's just a change in the display, if you continue to click on the header cell you will cycle through the different sort (ascending, descending and then no sort again).

As there's no changes in the model there's no action to undo. However, if you apply the sort using the corresponding button then the model will have been changed and the undo will be available.

Hope it helps.

p0la commented 8 years ago

Thanks for the fast answer. That helps a lot.

abe33 commented 8 years ago

Can I close the issue then?

p0la commented 8 years ago

Sure. Thx again