abe33 / atom-tree-view-breadcrumb

Display a breadcrumb on tree view scroll
MIT License
10 stars 3 forks source link

Uncaught TypeError: Cannot read property 'scrollTop' of null #10

Closed DavidLGoldberg closed 9 years ago

DavidLGoldberg commented 9 years ago

[Enter steps to reproduce below:]

  1. Have open the tree view.
  2. cmd + \ to close tree view
  3. cmd + \ to open tree view

Atom Version: 0.174.0 System: Mac OS X 10.9.4 Thrown From: tree-view-breadcrumb package, v0.4.0

Stack Trace

Uncaught TypeError: Cannot read property 'scrollTop' of null

At /Users/dgoldberg/.atom/packages/tree-view-breadcrumb/lib/breadcrumb-element.coffee:134

TypeError: Cannot read property 'scrollTop' of null
  at tree-view-breadcrumb.BreadcrumbElement.update (/Users/dgoldberg/.atom/packages/tree-view-breadcrumb/lib/breadcrumb-element.coffee:134:34)
  at /Users/dgoldberg/.atom/packages/tree-view-breadcrumb/lib/breadcrumb-element.coffee:130:8

Commands

  2x -0:00.0 tree-view:toggle (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)

Config

{
  "core": {
    "disabledPackages": [
      "neon-cursor",
      "recent-projects",
      "live-archive",
      "wakatime",
      "neon-selection",
      "minimap-highlight-selected"
    ],
    "themes": [
      "seti-ui",
      "seti-syntax"
    ],
    "audioBeep": false
  }
}

Installed Packages

# User
Search, v0.4.0
atom-color-highlight, v3.0.5
atom-lint, v0.20.1
build, v0.23.3
coffee-refactor, v0.6.2
color-picker, v1.4.3
command-logger, v0.20.0
copy-filename, v0.5.0
dash, v1.0.2
editor-stats, v0.16.0
git-log, v0.2.0
git-tab-status, v1.4.0
js-refactor, v0.3.0
language-aspx, v0.2.0
language-csharp, v0.3.0
language-generic-config, v0.1.3
language-gitignore, v0.1.1
language-splunk, v0.1.1
linter, v0.10.0
linter-write-good, v0.2.2
minimap, v3.5.6
minimap-color-highlight, v3.1.0
minimap-find-and-replace, v3.1.0
minimap-git-diff, v3.1.0
pain-split, v1.2.0
project-palette-finder, v2.4.9
recent-files, v0.3.0
refactor, v0.4.1
regex-railroad-diagram, v0.6.3
remote-sync, v2.3.1
rest-client, v0.3.1
seti-syntax, v0.2.1
seti-ui, v0.6.1
tabs-to-spaces, v0.8.0
test-status, v0.26.1
theme-roulette, v1.1.0
trailing-spaces, v0.2.4
tree-view-breadcrumb, v0.4.0
vim-mode, v0.29.0
vim-surround, v0.2.3
wordcount, v0.13.1

# Dev
keybinding-resolver, v0.26.0
theme-roulette, v1.1.0

/cc @atom/core

paradox460 commented 9 years ago

Happens when I open my editor without any context, fresh start too

abe33 commented 9 years ago

Thanks for the report, I'll take a look at that soon

SunDi3yansyah commented 9 years ago

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 0.186.0 System: linux 3.13.0-49-generic Thrown From: tree-view-breadcrumb package, v0.4.1

Stack Trace

Uncaught TypeError: Cannot read property 'scrollTop' of null

At /home/sundi3yansyah/.atom/packages/tree-view-breadcrumb/lib/breadcrumb-element.coffee:137

TypeError: Cannot read property 'scrollTop' of null
    at tree-view-breadcrumb.BreadcrumbElement.update (/home/sundi3yansyah/.atom/packages/tree-view-breadcrumb/lib/breadcrumb-element.coffee:216:40)
    at /home/sundi3yansyah/.atom/packages/tree-view-breadcrumb/lib/breadcrumb-element.coffee:208:17

Commands

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "seti-syntax"
    ]
  }
}

Installed Packages

# User
autocomplete-paths, v1.0.2
autocomplete-plus, v2.7.1
autocomplete-snippets, v1.2.0
color-picker, v1.6.0
emmet, v2.3.7
file-icons, v1.5.4
markdown-format, v2.5.0
minimap, v4.7.6
set-syntax, v0.2.1
seti-syntax, v0.3.3
tag, v0.2.3
tree-view-breadcrumb, v0.4.1
vim-mode, v0.43.0

# Dev
No dev packages
itamayo commented 9 years ago

I guess that the issue is that it runs some code before is loaded all the view. I did some test and it works fine if you comment 57th line of breadcrumb-element.coffee file. Anyway I am sure the author could give us better solution =)