search

abe33 / atom-tree-view-breadcrumb

Display a breadcrumb on tree view scroll
MIT License
10 stars 3 forks source link

Clickable breadcrumb #14

Closed eboracus closed 9 years ago

eboracus commented 9 years ago

To help with navigation through large directory structures, in addition to the current location finding, I think it could be a nice feature if the individual items in the breadcrumb were clickable and doing so would jump the current location of the main tree-view to that folder.

Also whilst trying to click on different folders in the trail I noticed the horizontal scroll doesn't seem to function so, depending on the 'Scroll To Last Item' setting, the view remains fixed at either the beginning or the end of the path.

abe33 commented 9 years ago

To help with navigation through large directory structures, in addition to the current location finding, I think it could be a nice feature if the individual items in the breadcrumb were clickable and doing so would jump the current location of the main tree-view to that folder.

This is the current behavior, or maybe I don't understand what you mean: breadcrumb-click

Also whilst trying to click on different folders in the trail I noticed the horizontal scroll doesn't seem to function so, depending on the 'Scroll To Last Item' setting, the view remains fixed at either the beginning or the end of the path.

Hmm, I'm not sure I fully understand the problem here, can you make me a screencap so that I can see what you're talking about?

eboracus commented 9 years ago

Apologies for the confusion, didn't test enough first. It turns out this is a conflict between this package and the tree-view-background package. Trying with that package disabled works perfectly as expected (scroll and click).

Not sure where the specific conflict lies, but it appears the breadcrumb path is appearing 'behind' the background image generated by the other package. As I had the image there set pretty transparent, the path was visible but not clickable. Example below of increasing opacity of the background image, note breadcrumb behind, tree view text in front of background:

breadcrumb_background2

Is it feasible to have the background/foreground 'order' of the breadcrumb path be brought forward to match the position of the main tree view file system? As in the example above there is no issue clicking the '.log' & 'version.ini' files.

I can open open an issue on tree-view-background if the problem lies there in not being far enough behind other objects.

abe33 commented 9 years ago

You can probably play with the elements z-index to make the breadcrumb appear above the rest. Originally the breadcrumb is not overlayed above the tree-view but is just appended in the tree-view-resizer (iirc) and affect the flex-box flow. I don't really now how tree-view-background works but a z-index should be enough.

Let me know if it solves things for you.

eboracus commented 9 years ago

Excellent, thanks for the info. Altering the index on this package had no effect on the order, the tree-view-background package specified no z-index explicitly so maybe that's why(?) Anyway I added an explicit index to ensure it remained at the back and all now works perfectly these two packages can co-exist it seems... awesome :sunglasses:

abe33 commented 9 years ago

Thanks for the feedback, I'll close this issue then.