search

abe33 / atom-tree-view-breadcrumb

Display a breadcrumb on tree view scroll
MIT License
10 stars 3 forks source link

Using command: 'Tree View: Reveal Active File' hides the breadcrumb #16

Open eboracus opened 9 years ago

eboracus commented 9 years ago

When using the 'synced-sidebar' package the breadcrumb disappears on changing the active tab. Looking into that package it seems it calls the 'Tree View: Reveal Active File command' automatically, I tried this with only breadcrumb enabled and experience the same disappearance.

Is this problem on the Tree View or the packages end? It would be nice to protect the breadcrumb from being hidden when this command is issued.

Edit: It seems like it may be happening only when the tree view is at the very top of the file structure. (Though certainly happens everywhere with the sync package calling the command as the focus is always on the current file). Here is an illustration manually issuing the command.

reveal_active_file

abe33 commented 9 years ago

Hmm, I don't reproduce this on my configuration (when manually triggering Tree View: Reveal Active File)

breadcrumb-reveal

When inspecting the tree view after that, can you still find the tree-view-breadcrumb element? Is there any styles applied that could explained why it disappear?

eboracus commented 9 years ago

I see you have the tree-view-open-files on there. I think that is the difference, as the open files' presence at the top of the tree-view are prohibiting the main file structure from appearing at the top at any time, which is the only time I see the behaviour occurring (I hope I got the edit down in time on the initial post above). Everything looks to work ok when the scrollbar is away from the top.

This issue certainly looks related to #15, as I see that the last file on the bottom comes back when the breadcrumb disappears, like the whole view is shifted back. Also, it seems to not be that the breadcrumb just gets killed on that command. If I scroll away from the top of the file tree by less than the height of the breadcrumb, and then call the command it only moves up off the top of the screen by that same amount, so some of the breadcrumb is still visible and the last file comes into view by the same degree. Once the scroll is more than the height of the breadcrumb there is no issue.

I checked using the tree-view-open-files and it all works (both issues not present) for me also in that case.

Partial breadcrumb disappearance: breadcrumb_treeview_partial

eboracus commented 8 years ago

Just wondering if there is any progress on this issue (along with the, related(?), #15)? I'm still seeing both on Atom v1.0.19 and breadcrumb v0.6.3 and think I remember it being the tree-view-open-files package obscuring both problems from view when also installed. Could you reproduce either issue without that package on?

abe33 commented 8 years ago

@eboracus actually there's 2 PR waiting in the tree-view package to solve the issues with different packages inserting content in the tree view (atom/tree-view#579 & atom/tree-view#578). I hope that when these two PRs will have been merged this kind of issues won't appear again.

eboracus commented 8 years ago

I see. Ok I'll keep an eye on those. Appreciate the efforts! :sunglasses:

eboracus commented 8 years ago

Just to note that I'm still seeing this. With the whole view shifting up and leaving a stretched status bar at the bottom of the window and a shrunken/completely swallowed tab bar off the top.

Though having the breadcrumb appear at the bottom of the page seems to stop it from happening(??) It's just not very accessible down there :(

Edit: Ah, I've just reviewed the gif above and it is indeed behaving differently now (didn't notice the change as I'd turned auto sync off). The issue seems to no longer be just within the tree-view pane alone, but is the whole window (all panes) moving together.

breadcrumb_wholewindowshift