abecderic / labyrinth

Explore the many rooms and corridors of Daedalus' labyrinth.
https://minecraft.curseforge.com/projects/daedalus-labyrinth
1 stars 1 forks source link

labyrinth+SpongeForge Server Crash #1

Closed knoxhack closed 8 years ago

knoxhack commented 8 years ago

https://gist.github.com/knoxhack/90370893525af2bc53eed8ef0e80dd4b

knoxhack commented 8 years ago

https://github.com/SpongePowered/SpongeForge/issues/890

abecderic commented 8 years ago

Without SpongeForge this bug does not exist.

The line containing the NPE is this

LabyrinthChunk chunk = Labyrinth.instance.worldData.getDataForChunk(x, z, world.rand);

In this line worldData is null. worldData is first set in the FMLServerStartingEvent (the code is here) which is not called before the crash, however FMLServerStartingEvent is called before worldgen when not using SpongeForge.

The event in the server lifecycle that is called earlier (FMLServerAboutToStartEvent) does not have the overworld loaded and so one can not get the world data from that event.

abecderic commented 8 years ago

Fixed in dev.