abecderic / labyrinth

Explore the many rooms and corridors of Daedalus' labyrinth.
https://minecraft.curseforge.com/projects/daedalus-labyrinth
1 stars 1 forks source link

modded mobs #9

Open Kashdeya opened 7 years ago

Kashdeya commented 7 years ago

working on a new pack idea and i have run into a issue where modded mobs are not able to spawn in the dim world. Is there any way you can add support for modded mob like Magma Monsters, hardcore wither, grue and so on ............ ?

A array to add the mobs might would be best if at all possible. so that we can pick which modded mobs we add to the dim world.

Thank you kashdeya

abecderic commented 7 years ago

The mobs should spawn in the labyrinth like in the overworld with regards to the biome they're in. The biomes in the labyrinth spawn like the biomes in the overworld; you might be in a biome that does not allow these mobs to spawn. Can they actually spawn naturally in the overworld? The Magma Monster sounds like it is a Nether mob. An array sounds like the best solution, maybe both a white- and blacklist.

Kashdeya commented 7 years ago

Magma Monsters are not a nether only spawn. I'm one of the devs for it. They spawn around lava blocks in the overworld. I have also installed other modded mobs and nothing is spawning. But with that said. When I first spawn in all the modded mobs spawn in with me then about 20 secs later they all despawn and are never seen again.

They seem to spawn fine in every other dim but the this one. I also agree a array would be best.

abecderic commented 7 years ago

I could track down the issue with the Magma Monsters so far: The getCanSpawnHere() method is overwritten in EntityMagmaMonster and returns false for all attempts of spawning it that I have observed. This method is where the spawning gets canceled. A quick search has not turned up any source code of the mod, so you'll have to look into it. (Version 0.1.15, default config)

The labyrinth has successfully spawned Ancient Golems from Embers so the issue is not with modded mobs in general, but just specific ones it seems.

vadis365 commented 7 years ago

Hello,

The Magma Monsters are set to spawn in any biome with lava below a certain height. The methods work fine and there are Nether and Overworld spawns working as intended.

The Entity Biome Spawning is here: https://github.com/vadis365/MagmaMonsters/blob/master/src/main/java/magma_monsters/MagmaMonsters.java#L59

and the Mob specific 'getCanSpawnHere()' method here https://github.com/vadis365/MagmaMonsters/blob/master/src/main/java/magma_monsters/entities/EntityMagmaMonster.java#L124

Cheers, Me.

abecderic commented 7 years ago

below a certain height

There's your problem. The labyrinth spawns at y=65. Once I changed the config value *Max Y Spawn Height from default 63 to 200 Magma Monsters spawned in the Labyrinth. Keep in mind that there is not much Lava where the mob can actually spawn in.

Keeping this issue open for {adding the mob black-/whitelist and removing biome-dependent spawns since the biomes aren't generated by the Labyrinth anyway}.