search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 26 forks source link

Coverage can't be turned off for debug #102

Closed jdavidpeter closed 2 years ago

jdavidpeter commented 2 years ago

This line enables coverage build: https://github.com/abedra/libvault/blob/5703ef4c171ee559669e97330ab86212b4cff3e4/CMakeLists.txt#L7 Even if ENABLE_COVERAGE is set to OFF: https://github.com/abedra/libvault/blob/5703ef4c171ee559669e97330ab86212b4cff3e4/CMakeLists.txt#L12 However, build links against gcov only if coverage is enabled: https://github.com/abedra/libvault/blob/5703ef4c171ee559669e97330ab86212b4cff3e4/CMakeLists.txt#L127-L128

jdavidpeter commented 2 years ago

Thank you!