search

abedra / libvault

A C++ library for Hashicorp Vault
MIT License
34 stars 26 forks source link

Improper use of std::string with curl C-API #111

Closed ajum closed 1 year ago

ajum commented 1 year ago

I think this should be a char * https://github.com/abedra/libvault/blob/bc7f8b5f7e76201712840ac56f2437c656650513/include/VaultClient.h#L253

And the following ternary should be (url && *url) ? https://github.com/abedra/libvault/blob/bc7f8b5f7e76201712840ac56f2437c656650513/include/VaultClient.h#L259